From 06ff4b750e548fe238a7444243a9eb7548154307 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Valdelvira?= Date: Wed, 19 Feb 2025 12:41:30 +0100 Subject: [PATCH] Fix some clippy warnings Changes: - Elid lifetimes when possible - Use a slice instead of a Vec as function argument - Rewrite &[b'*''] to b"*" --- src/input.rs | 4 ++-- src/lib.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/input.rs b/src/input.rs index ccb6594..b330328 100644 --- a/src/input.rs +++ b/src/input.rs @@ -6,7 +6,7 @@ pub enum Input<'a> { Stdin(io::StdinLock<'a>), } -impl<'a> Read for Input<'a> { +impl Read for Input<'_> { fn read(&mut self, buf: &mut [u8]) -> io::Result { match *self { Input::File(ref mut file) => file.read(buf), @@ -15,7 +15,7 @@ impl<'a> Read for Input<'a> { } } -impl<'a> Seek for Input<'a> { +impl Seek for Input<'_> { fn seek(&mut self, pos: SeekFrom) -> io::Result { fn try_skip(reader: R, pos: SeekFrom, err_desc: &'static str) -> io::Result where diff --git a/src/lib.rs b/src/lib.rs index bae2945..7057596 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -445,7 +445,7 @@ impl<'a, Writer: Write> Printer<'a, Writer> { if self.show_position_panel { match self.squeezer { Squeezer::Print => { - self.writer.write_all(&[b'*'])?; + self.writer.write_all(b"*")?; if self.show_color { self.writer.write_all(COLOR_RESET)?; } @@ -585,7 +585,7 @@ impl<'a, Writer: Write> Printer<'a, Writer> { Ok(()) } - fn reorder_buffer_to_little_endian(&self, buf: &mut Vec) { + fn reorder_buffer_to_little_endian(&self, buf: &mut [u8]) { let n = buf.len(); let group_sz = self.group_size as usize;